Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CONTRIBUTING): document guidance for preview APIs #16731

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Sep 30, 2021

With the commitment to not support breaking changes in stable modules (and all
of aws-cdk-lib), we need to document the standard for introducing APIs we know
to be potentially experimental or unstable.

This standard was originally proposed in https://github.com/aws/aws-cdk-rfcs/blob/master/text/0249-v2-experiments.md, and
was first actually used in #13780.

This task documents the standard in the CONTRIBUTING guide so we can use it as a
reference going forward.

closes #16434


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

With the commitment to not support breaking changes in stable modules (and all
of aws-cdk-lib), we need to document the standard for introducing APIs we know
to be potentially experimental or unstable.

This standard was originally proposed in https://github.com/aws/aws-cdk-rfcs/blob/master/text/0249-v2-experiments.md, and
was first actually used in #13780.

This task documents the standard in the CONTRIBUTING guide so we can use it as a
reference going forward.

closes #16434
@njlynch njlynch added this to the [GA] CDK V2 milestone Sep 30, 2021
@njlynch njlynch requested a review from a team September 30, 2021 11:38
@njlynch njlynch self-assigned this Sep 30, 2021
@gitpod-io
Copy link

gitpod-io bot commented Sep 30, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fb77ab2 into master Oct 11, 2021
@mergify mergify bot deleted the njlynch/doc-preview-apis branch October 11, 2021 17:12
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9192fed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at
Copy link
Contributor

nija-at commented Oct 12, 2021

I believe there are places in our repo today that don't follow this guidance. They use Experimental suffix and maybe the Pre. Vaguely recall that these are in the cloudfront and codebuild modules. Can we add a follow up item to fix these and bring them in line with the recommendation here?

Could you also make an announcement on the team email list about this? Feels like it warrants a wider PSA.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
With the commitment to not support breaking changes in stable modules (and all
of aws-cdk-lib), we need to document the standard for introducing APIs we know
to be potentially experimental or unstable.

This standard was originally proposed in https://github.com/aws/aws-cdk-rfcs/blob/master/text/0249-v2-experiments.md, and
was first actually used in aws#13780.

This task documents the standard in the CONTRIBUTING guide so we can use it as a
reference going forward.

closes aws#16434


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(docs): Updated guidance for preview APIs
4 participants