Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunctions-tasks): AWS SDK service integrations #16746

Merged
merged 17 commits into from
Oct 8, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Oct 1, 2021

Add support for Step Functions' AWS SDK integrations to call
any of the over two hundred AWS services directly from a state
machine.

See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/

Closes #16780


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 1, 2021

@jogold jogold marked this pull request as ready for review October 1, 2021 09:54
@jogold
Copy link
Contributor Author

jogold commented Oct 1, 2021

@kaizen3031593

@kaizencc kaizencc self-assigned this Oct 1, 2021
@kaizencc kaizencc self-requested a review October 1, 2021 13:31
@jogold jogold requested a review from RomainMuller October 6, 2021 15:38
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I have a few thoughts on documentation and am wondering why iamResources: ['*'] is the prevailing example throughout.

packages/@aws-cdk/aws-stepfunctions-tasks/README.md Outdated Show resolved Hide resolved
/**
* Properties for CallAwsService Task
*/
export interface CallAwsServiceProps extends sfn.TaskStateBaseProps {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for the documentation for these properties to be more robust in general? As someone without a ton of context for how to use this feature, I don't really gain much from the current documentation here.

@jogold jogold requested a review from kaizencc October 7, 2021 16:17
@mergify mergify bot dismissed kaizencc’s stale review October 7, 2021 16:17

Pull request has been modified.

@RomainMuller
Copy link
Contributor

I'll let @kaizen3031593 have the last word on this PR. At this stage, it looks functionally good to me 👍🏻

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 21db955
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ae840ff into aws:master Oct 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch pushed a commit that referenced this pull request Oct 11, 2021
Add support for Step Functions' AWS SDK integrations to call
any of the over two hundred AWS services directly from a state
machine.

See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/

Closes #16780 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add support for Step Functions' AWS SDK integrations to call
any of the over two hundred AWS services directly from a state
machine.

See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/

Closes aws#16780 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-stepfunctions-tasks): support AWS SDK service integrations
4 participants