-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions-tasks): AWS SDK service integrations #16746
Conversation
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I have a few thoughts on documentation and am wondering why iamResources: ['*']
is the prevailing example throughout.
packages/@aws-cdk/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Outdated
Show resolved
Hide resolved
/** | ||
* Properties for CallAwsService Task | ||
*/ | ||
export interface CallAwsServiceProps extends sfn.TaskStateBaseProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for the documentation for these properties to be more robust in general? As someone without a ton of context for how to use this feature, I don't really gain much from the current documentation here.
I'll let @kaizen3031593 have the last word on this PR. At this stage, it looks functionally good to me 👍🏻 |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add support for Step Functions' AWS SDK integrations to call any of the over two hundred AWS services directly from a state machine. See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/ Closes #16780 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for Step Functions' AWS SDK integrations to call any of the over two hundred AWS services directly from a state machine. See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/ Closes aws#16780 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for Step Functions' AWS SDK integrations to call
any of the over two hundred AWS services directly from a state
machine.
See https://docs.aws.amazon.com/step-functions/latest/dg/supported-services-awssdk.html
See https://aws.amazon.com/blogs/aws/now-aws-step-functions-supports-200-aws-services-to-enable-easier-workflow-automation/
Closes #16780
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license