fix(lambda): granting multiple conditional principals is not correctly configured #16782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
peterwoodworth
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
changed the title
|
Assigning to @rix0rrr since he's more familiar with the intricacies in IAM grants. |
nija-at
reviewed
Nov 5, 2021
Comment on lines
+114
to
+116
| "bundledDependencies": [ | ||
| "object-hash" | ||
| ], |
There was a problem hiding this comment.
You should be able to do crypto without having to use this dependency.
Nodejs' crypto library should suffice - https://nodejs.org/api/crypto.html#cryptocreatecipherivalgorithm-key-iv-options
rix0rrr
added
bug
|
This PR has been in BUILD FAILING for 21 days, and looks abandoned. It will be closed in 10 days if no further commits are pushed to it. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
github-actions
bot
added
the
closed-for-staleness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
grantInvoke()is called twice for the same service principal but with different conditions, only one resource policy was getting created. The reason was a conditional skip on policy creation based only on the principal (eg:s3.amazonaws.com) instead of checking the whole grantable object.Adding a more robust check based on the object hash to handle the cases similar to the conditional principal.
fixes #15710