Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): addSubscription returns the created Subscription #16785

Merged
merged 10 commits into from
Oct 26, 2021
Merged

feat(sns): addSubscription returns the created Subscription #16785

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ab60882
feat(sns): return subscription when adding
amirfireeye Oct 4, 2021
6e50156
Merge branch 'master' into patch-1
amirfireeye Oct 5, 2021
95c9c1b
Merge branch 'master' into patch-1
amirfireeye Oct 23, 2021
a963f73
Merge branch 'master' into patch-1
amirfireeye Oct 25, 2021
b9b5b0a
Try and add some tests
amirfireeye Oct 25, 2021
6368169
Fix spacing
amirfireeye Oct 25, 2021
b2c068e
Merge branch 'master' into patch-1
amirfireeye Oct 25, 2021
bc44ad6
Switch to user for easier matching
amirfireeye Oct 25, 2021
034fa00
Correct logical id
amirfireeye Oct 25, 2021
a527d54
Merge branch 'master' into patch-1
mergify[bot] Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-sns/lib/topic-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface ITopic extends IResource, notifications.INotificationRuleTarget
/**
* Subscribe some endpoint to this topic
*/
addSubscription(subscription: ITopicSubscription): void;
addSubscription(subscription: ITopicSubscription): Subscription;

/**
* Adds a statement to the IAM resource policy associated with this topic.
Expand Down Expand Up @@ -68,7 +68,7 @@ export abstract class TopicBase extends Resource implements ITopic {
/**
* Subscribe some endpoint to this topic
*/
public addSubscription(subscription: ITopicSubscription) {
public addSubscription(subscription: ITopicSubscription): Subscription {
const subscriptionConfig = subscription.bind(this);

const scope = subscriptionConfig.subscriberScope || this;
Expand All @@ -83,7 +83,7 @@ export abstract class TopicBase extends Resource implements ITopic {
throw new Error(`A subscription with id "${id}" already exists under the scope ${scope.node.path}`);
}

new Subscription(scope, id, {
return new Subscription(scope, id, {
topic: this,
...subscriptionConfig,
});
Expand Down