Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): VPC endpoint for AWS Xray #16788

Merged
merged 9 commits into from
Oct 28, 2021
Merged

feat(ec2): VPC endpoint for AWS Xray #16788

merged 9 commits into from
Oct 28, 2021

Conversation

zganger
Copy link
Contributor

@zganger zganger commented Oct 4, 2021

Adds a static instance of InterfaceVpcEndpointAwsService for Xray to simplify creation of endpoints for users. VPC endpoint support for XRay was launched in May.

Modeled this addition on #16306


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 4, 2021

@peterwoodworth peterwoodworth changed the title feat(ec2): VPC endpoint for AWS Xray feat(ec2): VPC endpoint for AWS Xray Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 21, 2021
@zganger
Copy link
Contributor Author

zganger commented Oct 22, 2021

I see that the PR validator failed because I did not change a README file. I am not sure this change is significant enough to need explicit documentation but I am happy to add to a README if necessary.

@njlynch njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 25, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@njlynch njlynch added the pr-linter/exempt-test The PR linter will not require test changes label Oct 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 72cc06f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c24af54 into aws:master Oct 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Nov 16, 2021
Adds static instances of InterfaceVpcEndpointAwsService for CodeGuru Profiler and Reviewer to simplify creation of endpoints for users. VPC endpoint support for CodeGuru is detailed for the [profiler](https://docs.aws.amazon.com/codeguru/latest/profiler-ug/private-link.html) and the [reviewer](https://docs.aws.amazon.com/codeguru/latest/reviewer-ug/vpc-interface-endpoints.html) in AWS documentation.

Modeled this addition on #16788 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mpvosseller pushed a commit to mpvosseller/aws-cdk that referenced this pull request Nov 16, 2021
Adds static instances of InterfaceVpcEndpointAwsService for CodeGuru Profiler and Reviewer to simplify creation of endpoints for users. VPC endpoint support for CodeGuru is detailed for the [profiler](https://docs.aws.amazon.com/codeguru/latest/profiler-ug/private-link.html) and the [reviewer](https://docs.aws.amazon.com/codeguru/latest/reviewer-ug/vpc-interface-endpoints.html) in AWS documentation.

Modeled this addition on aws#16788 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Adds a static instance of InterfaceVpcEndpointAwsService for Xray to simplify creation of endpoints for users. VPC endpoint support for XRay was [launched](https://aws.amazon.com/about-aws/whats-new/2021/05/aws-x-ray-now-supports-vpc-endpoints/) in May.

Modeled this addition on aws#16306 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Adds static instances of InterfaceVpcEndpointAwsService for CodeGuru Profiler and Reviewer to simplify creation of endpoints for users. VPC endpoint support for CodeGuru is detailed for the [profiler](https://docs.aws.amazon.com/codeguru/latest/profiler-ug/private-link.html) and the [reviewer](https://docs.aws.amazon.com/codeguru/latest/reviewer-ug/vpc-interface-endpoints.html) in AWS documentation.

Modeled this addition on aws#16788 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants