Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assertions): matcher support for templateMatches() API #16789

Merged
merged 3 commits into from
Oct 5, 2021

Commits on Oct 4, 2021

  1. feat(assertions): Matcher support for templateMatches() API

    The `templateMatches()` API behaved differently from the rest of the
    `hasXxx()` and `findXxx()` APIs in that it did not accept a Matcher.
    This functionality is generally useful to perform partial matching on
    the full template.
    
    Further, users can get confused and assume that the `templateMatches()`
    API do support Matchers, as this is the only one that is an exception.
    
    Align this API with the rest of the module's behaviour.
    
    A nice side effect of this is that this module no longer needs to vendor
    in changes from the 'assert' module and brings this in line with the
    other modules in this repo.
    
    nozem can work again! 🙌
    Niranjan Jayakar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    1886f14 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. fix ivs

    Niranjan Jayakar committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    a497be5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into nija-at/assertions-removeassert

    Niranjan Jayakar authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    68ea70f View commit details
    Browse the repository at this point in the history