Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rollback GenericSSMParameterImage deprecation (backport #16798) #16800

Merged
merged 1 commit into from
Oct 5, 2021
+5 −3
Merged

chore: rollback GenericSSMParameterImage deprecation (backport #16798) #16800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/@aws-cdk/aws-ec2/lib/machine-image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,12 @@ export interface MachineImageConfig {
* on the instance if you are using this image.
*
* The AMI ID is selected using the values published to the SSM parameter store.
*
* @deprecated Use `MachineImage.fromSsmParameter()` instead
*/
export class GenericSSMParameterImage implements IMachineImage {
// FIXME: this class ought to be `@deprecated` and removed from v2, but that
// is causing build failure right now. Ref: https://github.com/aws/jsii/issues/3025
// @-deprecated Use `MachineImage.fromSsmParameter()` instead

/**
* Name of the SSM parameter we're looking up
*/
Expand Down Expand Up @@ -679,4 +681,4 @@ function lookupImage(scope: Construct, cachedInContext: boolean | undefined, par
return cachedInContext
? ssm.StringParameter.valueFromLookup(scope, parameterName)
: ssm.StringParameter.valueForTypedStringParameter(scope, parameterName, ssm.ParameterType.AWS_EC2_IMAGE_ID);
}
}