fix(cloudfront): EdgeFunctions cannot be created when IDs contain spaces #16845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EdgeFunction uses a SSM string parameter under the hood to pass the Function ARN between the different regions. The name of the parameter is derived from the node path; this path may contain characters (e.g., spaces) that are invalid as SSM parameter names. Two fixes here: introduce new validation for SSM parameter names, and sanitize the path prior to passing to SSM. fixes #16832
|
|
otaviomacedo
approved these changes
Oct 7, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Oct 11, 2021
…ces (#16845) The EdgeFunction uses a SSM string parameter under the hood to pass the Function ARN between the different regions. The name of the parameter is derived from the node path; this path may contain characters (e.g., spaces) that are invalid as SSM parameter names. Two fixes here: introduce new validation for SSM parameter names, and sanitize the path prior to passing to SSM. fixes #16832 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ces (aws#16845) The EdgeFunction uses a SSM string parameter under the hood to pass the Function ARN between the different regions. The name of the parameter is derived from the node path; this path may contain characters (e.g., spaces) that are invalid as SSM parameter names. Two fixes here: introduce new validation for SSM parameter names, and sanitize the path prior to passing to SSM. fixes aws#16832 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EdgeFunction uses a SSM string parameter under the hood to pass the Function
ARN between the different regions. The name of the parameter is derived from the
node path; this path may contain characters (e.g., spaces) that are invalid as
SSM parameter names.
Two fixes here: introduce new validation for SSM parameter names, and sanitize
the path prior to passing to SSM.
fixes #16832
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license