fix(lambda): currentVersion fails when architecture specified #16849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause for this is that the new 'Architecture' property added to the CloudFormation specification is not classified as version locked or not. Added a test to ensure that any missing properties are caught in the future. Further, deprecated the `architectures` property and replaced with a singular `architecture` prop. Lambda Functions only support one architecture. Additionally, removed the CFN spec patch, now that the CloudFormation resource specification includes the Architecture fields. fixes #16814
eladb
approved these changes
Oct 7, 2021
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
Update doc to reflect deprecation from #16849 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
The cause for this is that the new 'Architecture' property added to the CloudFormation specification is not classified as version locked or not. Added a test to ensure that any missing properties are caught in the future. Further, deprecated the `architectures` property and replaced with a singular `architecture` prop. Lambda Functions only support one architecture. Additionally, removed the CFN spec patch, now that the CloudFormation resource specification includes the Architecture fields. fixes #16814 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
) The cause for this is that the new 'Architecture' property added to the CloudFormation specification is not classified as version locked or not. Added a test to ensure that any missing properties are caught in the future. Further, deprecated the `architectures` property and replaced with a singular `architecture` prop. Lambda Functions only support one architecture. Additionally, removed the CFN spec patch, now that the CloudFormation resource specification includes the Architecture fields. fixes aws#16814 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Update doc to reflect deprecation from aws#16849 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause for this is that the new 'Architecture' property added to the
CloudFormation specification is not classified as version locked or not.
Added a test to ensure that any missing properties are caught in the
future.
Further, deprecated the
architecturesproperty and replaced with asingular
architectureprop. Lambda Functions only support onearchitecture.
Additionally, removed the CFN spec patch, now that the CloudFormation
resource specification includes the Architecture fields.
fixes #16814
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license