You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwoodworth
changed the title
fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer
fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer
Oct 21, 2021
nija-at
changed the title
fix(apigatewayv2-authorizers): allow multiple userPoolClients for HttpUserPoolAuthorizer
feat(apigatewayv2-authorizers): http api - allow multiple user pools for HttpUserPoolAuthorizer
Nov 5, 2021
Hi @nija-at, thanks for the review! I added a test for that.
Also please be aware that this PR does NOT add support for multiple user pools, but multiple user pool clients. CFn only allows one user pool per Jwt authorizer. So I think this PR title is a bit misleading.
nija-at
changed the title
feat(apigatewayv2-authorizers): http api - allow multiple user pools for HttpUserPoolAuthorizer
feat(apigatewayv2-authorizers): http api - allow multiple user pool clients per HttpUserPoolAuthorizer
Nov 6, 2021
Hi @nija-at, thanks for the review! I added a test for that. Also please be aware that this PR does NOT add support for multiple user pools, but multiple user pool clients. CFn only allows one user pool per Jwt authorizer. So I think this PR title is a bit misleading.
Ah, thanks for the clarification! I've updated the title.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
…lients per HttpUserPoolAuthorizer (#16903)
closes#15431
BREAKING CHANGE: `userPoolClient` property in `UserPoolAuthorizerProps`
is now renamed to `userPoolClients`.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…lients per HttpUserPoolAuthorizer (aws#16903)
closesaws#15431
BREAKING CHANGE: `userPoolClient` property in `UserPoolAuthorizerProps`
is now renamed to `userPoolClients`.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peterwoodworth
changed the title
github-actions
bot
added
the
@aws-cdk/aws-apigatewayv2-authorizers
nija-at
changed the title
closes #15431
BREAKING CHANGE:
userPoolClientproperty inUserPoolAuthorizerPropsis now renamed to
userPoolClients.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license