Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): improve messaging when property type cannot be determined #16907

Merged
merged 3 commits into from
Oct 12, 2021
Merged

chore(cfnspec): improve messaging when property type cannot be determined #16907

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c2f2bb
chore(cfnspec): improve messaging when property type cannot be determ…
Oct 11, 2021
db95f12
Merge branch 'master' into nija-at/fix-validator-msg
mergify[bot] Oct 12, 2021
93d1ee9
Merge branch 'master' into nija-at/fix-validator-msg
mergify[bot] Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@aws-cdk/cfnspec/test/spec-validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ function validateProperties(

} else {
// eslint-disable-next-line no-console
console.error(`${typeName}.Properties.${name} has known type: ${JSON.stringify(property)}`);
console.error(`${typeName}.Properties.${name} does not declare a type.` +
`Property definition is: ${JSON.stringify(property, undefined, 2)}`);
expect(false).toBeTruthy();
}

Expand Down