Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cx-api): return type of futureFlagDefault is incorrect #17026

Merged
merged 2 commits into from
Oct 27, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/cx-api/lib/features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,6 @@ const FUTURE_FLAGS_DEFAULTS: { [key: string]: boolean } = {
[CLOUDFRONT_DEFAULT_SECURITY_POLICY_TLS_V1_2_2021]: false,
};

export function futureFlagDefault(flag: string): boolean {
export function futureFlagDefault(flag: string): boolean | undefined {
return FUTURE_FLAGS_DEFAULTS[flag];
}
4 changes: 4 additions & 0 deletions packages/@aws-cdk/cx-api/test/features.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ test('all future flags have defaults configured', () => {
});
});

test('futureFlagDefault returns undefined if non existent flag was given', () => {
expect(feats.futureFlagDefault('non-existent-flag')).toEqual(undefined);
});

testLegacyBehavior('FUTURE_FLAGS_EXPIRED must be empty in CDKv1', Object, () => {
expect(feats.FUTURE_FLAGS_EXPIRED.length).toEqual(0);
});