-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logs): Apply tags to log retention Lambda #17029
fix(logs): Apply tags to log retention Lambda #17029
Conversation
Hi @jamesorlakin, I changed your PR a bit to improve the programming experience for you and other people going forward (by removing the use of However, I am unable to push my change back to your branch in order to merge it: Do you have Allow edits from maintainers switched off by any chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cherry-pick commit c1fd7969c into this PR
Nevermind I figured it out |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thanks @rix0rrr, your solution is definitely snazzier than mine! |
This hopefully fixes aws#15032 by implementing the `ITaggable` interface on the custom construct and then applying discovered tags to the underlying `CfnResource`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This hopefully fixes #15032 by implementing the
ITaggable
interface on the custom construct and then applying discovered tags to the underlyingCfnResource
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license