docs(appsync): make examples compile #17045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaizencc
commented
Oct 18, 2021
rix0rrr
requested changes
Oct 19, 2021
kaizencc
commented
Oct 19, 2021
| @@ -537,48 +550,38 @@ Above we see a schema that allows for generating paginated responses. For exampl | |||
| we can query `allFilms(first: 100)` since `FilmConnection` acts as an intermediary | |||
| for holding `FilmEdges` we can write a resolver to return the first 100 films. | |||
|
|
|||
There was a problem hiding this comment.
Just marking this location for convenience -- PR comments are about the example below (too long to block comment).
| @@ -799,34 +809,28 @@ You can create Object Types in three ways: | |||
| }, | |||
| }); | |||
|
|
|||
| api.addType(object); | |||
| api.addType(demo); | |||
| ``` | |||
|
|
|||
| > This method allows for reusability and modularity, ideal for larger projects. | |||
| For example, imagine moving all Object Type definition outside the stack. | |||
|
|
|||
There was a problem hiding this comment.
PR comments are also about this example.
rix0rrr
approved these changes
Oct 19, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license