fix(pipelines): additionalInputs fails for deep directory

[rix0rrr]

If the directory is nested deeper than one level underneath . or ..,
the wrong directory gets created.

Also add in protection against the directory already existing, in which
case the same behavior would happen.

Fixes #16936.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 5666e7f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[fab-mindflow]

Hi @rix0rrr,

This PR looks like it has introduced a failure on my current pipeline.
I am using additionalInputs in a CodeBuildStep to import a directory created from the previous CodeBuildStep.

    // Step 1
    const step1 = new CodeBuildStep("Step1", {
      primaryOutputDirectory: "/tmp/myfolder",
      // ...
    })

    const step2 = new CodeBuildStep("Step2", {
      additionalInputs: { "./step1": step1 },
      // ...
    })

This now stops the build with the following error:

[Container] 2021/10/28 06:05:31 Running command [[ ! -d "./step1" ]] || { echo 'additionalInputs: "./step1" must not exist yet. If you want to merge multiple artifacts, use a "cp" command.'; exit 1; } && ln -s -- "$CODEBUILD_SRC_DIR_Step1_Output" "./step1"
/codebuild/output/tmp/script.sh: 4: [[: not found
additionalInputs: "./step1" must not exist yet. If you want to merge multiple artifacts, use a "cp" command.

Am I doing something wrong? Or is this a regression?

[kyri-petrou]

Experiencing the same issue as @fab-mindflow. Could you please advice whether the behaviour of additionalInputs has changed?

[rix0rrr]

This was a regression that was fixed in #17279