Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix README - change Construct to Stage #17079

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Conversation

kwiest
Copy link
Contributor

@kwiest kwiest commented Oct 20, 2021

A Stage is meant to hold collections of Stacks as a unit of deployment.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

A Stage is meant to hold collections of Stacks as a unit of deployment.
@gitpod-io
Copy link

gitpod-io bot commented Oct 20, 2021

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the change here as well?

@kwiest
Copy link
Contributor Author

kwiest commented Oct 20, 2021

Can you make the change here as well?

You got it. Thank you

@mergify mergify bot dismissed peterwoodworth’s stale review October 20, 2021 22:30

Pull request has been modified.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks 😊

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3a5460c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5f7c58b into aws:master Oct 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
A Stage is meant to hold collections of Stacks as a unit of deployment.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants