Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): stop hard-coding partition to 'aws' in hotswapping #17085

Merged
merged 10 commits into from
Oct 22, 2021
Merged

chore(cli): stop hard-coding partition to 'aws' in hotswapping #17085

merged 10 commits into from
Oct 22, 2021

Conversation

comcalvi
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@comcalvi comcalvi requested a review from skinny85 October 21, 2021 00:47
@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2021

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 21, 2021
@comcalvi comcalvi changed the title (cli): Handle Partitions better in hotswapping chore(cli): Handle Partitions better in hotswapping Oct 21, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 21, 2021
skinny85
skinny85 suggested changes Oct 21, 2021
View reviewed changes
packages/aws-cdk/lib/api/hotswap-deployments.ts Outdated Show resolved Hide resolved
packages/aws-cdk/lib/api/hotswap-deployments.ts Outdated Show resolved Hide resolved
@comcalvi comcalvi requested a review from skinny85 October 21, 2021 18:54
@comcalvi comcalvi requested a review from skinny85 October 21, 2021 19:04
@skinny85 skinny85 changed the title chore(cli): Handle Partitions better in hotswapping chore(cli): stop hard-coding partition to 'aws' in hotswapping Oct 21, 2021
skinny85
skinny85 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5e72106
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a0d4ee7 into aws:master Oct 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@comcalvi @TikiTDO
chore(cli): stop hard-coding partition to 'aws' in hotswapping (aws#1…
bb89f8d 
…7085)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comcalvi @aws-cdk-automation @skinny85 @rix0rrr