Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codebuild): add forgotten rosetta fixture #17129

Merged
merged 3 commits into from
Oct 23, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 23, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team October 23, 2021 09:43
@rix0rrr rix0rrr self-assigned this Oct 23, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Oct 23, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 23, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 188ce13
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@@ -0,0 +1,19 @@
// Fixture with packages imported, but nothing else
import { Construct } from 'constructs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Construct imported from 'constructs' and not @aws-cdk/core?

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you made a conscious decision on my question, I'm just going to approve it first. It doesn't seem to be incorrect, just not what I was expecting.

@mergify mergify bot merged commit 924045d into master Oct 23, 2021
@mergify mergify bot deleted the huijbers/codebuild-examples-2 branch October 23, 2021 14:16
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants