Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stepfunctions): make examples compile #17141

Merged
merged 6 commits into from
Oct 26, 2021
Merged

docs(stepfunctions): make examples compile #17141

merged 6 commits into from
Oct 26, 2021

Conversation

kaizencc
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2021

@kaizencc kaizencc requested a review from rix0rrr October 25, 2021 15:06
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Oct 25, 2021
@kaizencc kaizencc requested a review from a team October 25, 2021 15:06
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 25, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 25, 2021

Ruh roh:

Error: Expected to find import statement in aws-cdk-lib.aws_stepfunctions README: import * as cdk from 'aws-cdk-lib';

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's just put one of the imports back into the visible source.

@njlynch
Copy link
Contributor

njlynch commented Oct 25, 2021

Ruh roh:

Error: Expected to find import statement in aws-cdk-lib.aws_stepfunctions README: import * as cdk from 'aws-cdk-lib';

For now, let's just put one of the imports back into the visible source.

Oooh, but I really want to update this counter now!

// Count of times this test has been broken by README updates so far (please increment as necessary! :D): 0

@kaizencc
Copy link
Contributor Author

🤦 it is actually the second time, Rico never lets me update the counter :)

@njlynch
Copy link
Contributor

njlynch commented Oct 25, 2021

🤦 it is actually the second time, Rico never lets me update the counter :)

Let's just do it. You can switch the test to use rds instead of stepfunctions, I think. It has the same import.

@kaizencc
Copy link
Contributor Author

kaizencc commented Oct 25, 2021

Oh... but I'm currently doing the same thing for rds, can we switch to the amplify module instead? Or we'll have to update counter to 2 momentarily... @njlynch

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ba89484
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e1bf1b9 into aws:master Oct 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants