Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): support backtrackWindow in DatabaseCluster #17160

Merged
merged 2 commits into from
Oct 26, 2021
Merged

feat(rds): support backtrackWindow in DatabaseCluster #17160

merged 2 commits into from
Oct 26, 2021

Conversation

jamesorlakin
Copy link
Contributor

@jamesorlakin jamesorlakin commented Oct 26, 2021 •
edited by skinny85
Loading

This is a small PR to fix #9369 without needing to use an escape hatch.

Fixes #9369

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 26, 2021

@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Oct 26, 2021
@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 26, 2021
skinny85
skinny85 approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jamesorlakin!

@skinny85 skinny85 changed the title feat(aws-rds): Add backtrackWindow to DatabaseCluster feat(rds): support backtrackWindow in DatabaseCluster Oct 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 694686d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fcd17e9 into aws:master Oct 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 mentioned this pull request Oct 29, 2021
Closed
2 tasks
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jamesorlakin @TikiTDO
feat(rds): support backtrackWindow in DatabaseCluster (aws#17160)
803e6e4 
This is a small PR to fix aws#9369 without needing to use an escape hatch.

Fixes  aws#9369

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-rds] Add BacktrackWindow prop to DatabaseCluster construct/ DatabaseClusterProps for Aurora DBs
3 participants
@jamesorlakin @aws-cdk-automation @skinny85