chore: activate 'rosetta infuse' feature #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kaizencc
approved these changes
Oct 27, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@rix0rrr sounds interesting! Do you have an example of how these infused examples might look? |
|
@eladb this is actuall the "real examples that get copied around", so they look just like normal examples from the READMEs. Kaizen is working in parallel on a "synthetic usage example" feature which will be coming up soon. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
The examples we copy into docblocks may contain block comments themselves.
However, the docblock renderer does not escape the docblock *closing* text, so the doc block gets terminated early and compiling fails:
```java
/**
* Initialization props for the `NestedStack` construct.
* <p>
* Example:
* <p>
* <blockquote><pre>{@code
* // Example automatically generated. See aws/jsii#826
* import software.amazon.awscdk.core.App;
* import software.amazon.awscdk.core.CfnOutput;
* import software.amazon.awscdk.core.NestedStack;
* import lib.RestApi;
* import lib.Stage;
* /**
* * This file showcases how to split up a RestApi's Resources and Methods across nested stacks.
* *
* * The root stack 'RootStack' first defines a RestApi.
* * Two nested stacks BooksStack and PetsStack, create corresponding Resources '/books' and '/pets'.
* * They are then deployed to a 'prod' Stage via a third nested stack - DeployStack.
* *
* * To verify this worked, go to the APIGateway
* */ <------------ OOOPS!
* public class RootStack extends Stack {
* public RootStack(Construct scope) {
* super(scope, "integ-restapi-import-RootStack");
* RestApi restApi = RestApi.Builder.cre
```
Revert this until we can address the quoting issue.
Reverts #17191
rix0rrr
added a commit
that referenced
this pull request
Nov 3, 2021
`jsii-rosetta infuse` will modify all the assemblies in-place to add examples to types that don't have examples yet. This feature depends on jsii 1.41, and should not be merged before jsii has been upgraded to that version (either by #17187 or by #17190). Depends-On: #17190 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
`jsii-rosetta infuse` will modify all the assemblies in-place to add examples to types that don't have examples yet. This feature depends on jsii 1.41, and should not be merged before jsii has been upgraded to that version (either by #17187 or by #17190). Depends-On: #17190 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
iliapolo
added a commit
that referenced
this pull request
Nov 4, 2021
iliapolo
added a commit
that referenced
this pull request
Nov 4, 2021
rix0rrr
added a commit
that referenced
this pull request
Nov 9, 2021
`jsii-rosetta infuse` will modify all the assemblies in-place to add examples to types that don't have examples yet. This feature depends on jsii 1.41, and should not be merged before jsii has been upgraded to that version (either by #17187 or by #17190). Depends-On: #17190 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
`jsii-rosetta infuse` will modify all the assemblies in-place to add examples to types that don't have examples yet. This feature depends on jsii 1.41, and should not be merged before jsii has been upgraded to that version (either by aws#17187 or by aws#17190). Depends-On: aws#17190 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The examples we copy into docblocks may contain block comments themselves.
However, the docblock renderer does not escape the docblock *closing* text, so the doc block gets terminated early and compiling fails:
```java
/**
* Initialization props for the `NestedStack` construct.
* <p>
* Example:
* <p>
* <blockquote><pre>{@code
* // Example automatically generated. See aws/jsii#826
* import software.amazon.awscdk.core.App;
* import software.amazon.awscdk.core.CfnOutput;
* import software.amazon.awscdk.core.NestedStack;
* import lib.RestApi;
* import lib.Stage;
* /**
* * This file showcases how to split up a RestApi's Resources and Methods across nested stacks.
* *
* * The root stack 'RootStack' first defines a RestApi.
* * Two nested stacks BooksStack and PetsStack, create corresponding Resources '/books' and '/pets'.
* * They are then deployed to a 'prod' Stage via a third nested stack - DeployStack.
* *
* * To verify this worked, go to the APIGateway
* */ <------------ OOOPS!
* public class RootStack extends Stack {
* public RootStack(Construct scope) {
* super(scope, "integ-restapi-import-RootStack");
* RestApi restApi = RestApi.Builder.cre
```
Revert this until we can address the quoting issue.
Reverts aws#17191
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
`jsii-rosetta infuse` will modify all the assemblies in-place to add examples to types that don't have examples yet. This feature depends on jsii 1.41, and should not be merged before jsii has been upgraded to that version (either by aws#17187 or by aws#17190). Depends-On: aws#17190 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii-rosetta infusewill modify all the assemblies in-place toadd examples to types that don't have examples yet.
This feature depends on jsii 1.41, and should not be merged before
jsii has been upgraded to that version (either by #17187 or by #17190).
Depends-On: #17190
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license