Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iot-actions): add the action to put CloudWatch Logs #17228

Merged
merged 7 commits into from
Nov 2, 2021
Merged

feat(iot-actions): add the action to put CloudWatch Logs #17228

merged 7 commits into from
Nov 2, 2021

Conversation

yamatatsu
Copy link
Contributor

I'm trying to implement aws-iot L2 Constructs.

This PR is one of steps after following PR:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 29, 2021

@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Oct 29, 2021
@yamatatsu yamatatsu force-pushed the aws-iot-actions-logs branch from 5bae759 to e2c6b0b Compare October 29, 2021 14:56
@yamatatsu
Copy link
Contributor Author

yamatatsu commented Oct 29, 2021 •
edited
Loading

I wonder about new actions.CloudwatchLogsAction(logGroup) constructor that which is better to implement to need property logGroup or not.

now:

new actions.CloudwatchLogsAction(logGroup)

Or we can implement to create logs in constructor if the property not be given as following:

new actions.CloudwatchLogsAction()

@skinny85
Copy link
Contributor

I wonder about new actions.CloudwatchLogsAction(logGroup) constructor that which is better to implement to need property logGroup or not.

now:

new actions.CloudwatchLogsAction(logGroup)

Or we can implement to create logs in constructor if the property not be given as following:

new actions.CloudwatchLogsAction()

Let's start with the first one. It's simpler, and if we ever want to make logGroup optional later, we can - it will be a backwards-compatible change.

@yamatatsu
feat(iot-actions): Add the action to put CloudWatch Logs
b280868 
1. add the action
2. add tests
3. describe to README
@yamatatsu yamatatsu force-pushed the aws-iot-actions-logs branch from e2c6b0b to b280868 Compare October 30, 2021 01:41
@yamatatsu
Copy link
Contributor Author

@skinny85
Thank you for your reply! You've made me feel more confident 😀

@yamatatsu
Copy link
Contributor Author

@madeline-k
This is ready to be reviewed now!

@skinny85 skinny85 assigned skinny85 and unassigned madeline-k Nov 1, 2021
skinny85
skinny85 previously requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, as always @yamatatsu! A few tiny comments before we merge this in 🙂.

packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-logs-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-logs-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/private/role.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-logs-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch-logs/cloudwatch-logs-action.test.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review November 2, 2021 07:49

Pull request has been modified.

@yamatatsu yamatatsu requested a review from skinny85 November 2, 2021 09:29
skinny85
skinny85 previously approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change needed. I'll do it myself though 😉.

packages/@aws-cdk/aws-iot-actions/README.md Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Nov 2, 2021
@mergify mergify bot dismissed skinny85’s stale review November 2, 2021 16:42

Pull request has been modified.

skinny85
skinny85 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff as always @yamatatsu!

@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Nov 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8265df4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a7c869e into aws:master Nov 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yamatatsu yamatatsu mentioned this pull request Nov 4, 2021
Merged
@yamatatsu yamatatsu changed the title feat(iot-actions): Add the action to put CloudWatch Logs feat(iot-actions): add the action to put CloudWatch Logs Nov 4, 2021
@yamatatsu yamatatsu deleted the aws-iot-actions-logs branch November 5, 2021 01:39
@skinny85 skinny85 mentioned this pull request Nov 9, 2021
Closed
2 tasks
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@yamatatsu @TikiTDO
feat(iot-actions): Add the action to put CloudWatch Logs (aws#17228)
d532d9f 
I'm trying to implement aws-iot L2 Constructs.

This PR is one of steps after following PR: 
- aws#16681 (comment)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch @aws-cdk/aws-iot-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamatatsu @skinny85 @aws-cdk-automation @madeline-k