Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms): have EncryptionKeyBase implement IEncryptionKey #1728

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

sam-goodwin
Copy link
Contributor

Fixes #1530

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin requested a review from a team as a code owner February 11, 2019 16:40
@eladb
Copy link
Contributor

eladb commented Feb 11, 2019

awslint would have caught this if the name of the construct would have been Key (which it should be).

@sam-goodwin sam-goodwin merged commit 49080c6 into master Feb 11, 2019
@sam-goodwin sam-goodwin deleted the samgood/kms-encryptionkey branch February 11, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't specify kms.EncryptionKey for s3.BucketProps and codebuild.ProjectProps EncryptionKey property for .NET
2 participants