-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2): http api - mTLS support #17284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR @serahisaactho.
@serahisaactho - once approved, please do not update the branch from master. Our merge bot will do everything for you. Any manual changes you make will revert the approval. |
@nija-at Sorry! Thanks for taking a look |
@nija-at It looks like the build is not successful which is blocking the merge. Can I update my branch to see what is causing the build failure? |
That's weird that the build failed. I've restarted the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serahisaactho - Your unit tests are failing. See the build logs linked above.
@nija-at Will fix them. |
@nija-at I've updated the unit tests. The build is succeeding now. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Resolves aws#12559 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Resolves #12559
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license