fix(lambda): SAM CLI asset metadata missing from image Functions #17368
Conversation
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
packages/@aws-cdk/aws-lambda/test/docker-lambda-handler/Dockerfile
Outdated
Show resolved
Hide resolved
torresxb1
changed the title
…into image-lambda-metadata
| * If asset staging is disabled, this will just be the original path. | ||
| * If asset staging is enabled it will be the staged path. | ||
| */ | ||
| public readonly assetPath: string; |
There was a problem hiding this comment.
Do these all really need to be public ? I would be fine if they were private, and your feature would still work.
| entrypoint: this.props.entrypoint, | ||
| cmd: this.props.cmd, | ||
| workingDirectory: this.props.workingDirectory, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| public bindToResource(resource: cdk.CfnResource, options: ResourceBindOptions = { }) { |
There was a problem hiding this comment.
Was this function already there?
There was a problem hiding this comment.
yes, this function is already defined in Code class
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
rix0rrr
changed the title
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…#17368) Adds asset metadata to image-type lambda functions. This will allow SAM CLI to support local invocation of image-type lambdas from CDK-synthed templates. It follows the same design and builds upon aws#1433 Fixes aws#14593 Uses some changes from aws#17293 to enable asset metadata generation in integration tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#17368) Adds asset metadata to image-type lambda functions. This will allow SAM CLI to support local invocation of image-type lambdas from CDK-synthed templates. It follows the same design and builds upon aws#1433 Fixes aws#14593 Uses some changes from aws#17293 to enable asset metadata generation in integration tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds asset metadata to image-type lambda functions. This will allow SAM CLI to support local invocation of image-type lambdas from CDK-synthed templates.
It follows the same design and builds upon #1433
Fixes #14593
Uses some changes from #17293 to enable asset metadata generation in integration tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license