Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2): http api - IAM authorizer support #17519
feat(apigatewayv2): http api - IAM authorizer support #17519
Changes from 45 commits
01ee864
b036ab6
c928252
7651962
f68870e
7baa434
a83a262
7190cbd
7275bfa
7384149
dad0441
9e4440d
b8c6f3f
6af5796
cf677de
d8fa36e
1b36d28
3326856
1a18251
e15ad8b
b061e12
876a361
962c301
48eaa71
ec66563
fc5f640
1ff91a6
de50380
58d1596
a9875db
b14b947
df4bfaf
089f7ba
ba92c36
7517d0b
58f1e26
11bdde5
6dc6fb1
d250a74
bf7e077
d31de47
5bd8bf6
488fd39
f546da0
1afe120
63bb1ff
c9dc5b1
2d11bc5
b487850
007b1bd
fd3e10a
e1e4a73
8452922
90ce8cf
fb51b90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] Now that
key
can be derived from the other two attributes, I would remove it from the constructor to make it cleaner and avoid mistakes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now simplified this section so that it's cleaner and easier to avoid mistakes. As far as I can see, HTTP API has only the
$default
andMETHOD /path/here
formats forkey
, so this should work. https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-routes.htmlLet me know whether this change works for you.