Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): merge cloudFormation tags with aspect tags #1762

Merged
merged 14 commits into from
Mar 13, 2019
Merged

fix(cdk): merge cloudFormation tags with aspect tags #1762

merged 14 commits into from
Mar 13, 2019

Commits on Feb 14, 2019

  1. fix(cdk): merge cloudFormation tags with aspect tags 

    This modifies the behavior of TagManager to enable the merging of tags
provided during Cfn* properties with tag aspects. If a collision occurs
the aspects tag precedence.

fixes aws#1725
    @moofish32
    moofish32 committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    9a3fade View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. refactoring tag-manager to avoid JSII errors for complex dictionary t… 

    …ypes; adding in additional tests
    @moofish32
    moofish32 committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    65c0596 View commit details
    Browse the repository at this point in the history

  2. removing export from classes that do not need it, asg tag interface 

    fully defined
    @moofish32
    moofish32 committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    18ce625 View commit details
    Browse the repository at this point in the history

  3. can not resolve early; note - go back and consider changing the defau… 

    …lt tag type
    @moofish32
    moofish32 committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    4305741 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. refactor tags using Map

    @moofish32
    moofish32 committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    708eff3 View commit details
    Browse the repository at this point in the history

  2. trigger retest'

    @moofish32
    moofish32 committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    455d697 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. refactoring to enable tag formatters to parse L1 tags, remove merge l… 

    …ogic, set priority defaults with space between values, code generation now passes in L1 tags
    @moofish32
    moofish32 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    15aa430 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into b-child-tag-merge

    @moofish32
    moofish32 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    15da077 View commit details
    Browse the repository at this point in the history

  3. fixing codegen.ts missing arg to constructor

    @moofish32
    moofish32 committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8eebcc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Remove Tokens from cfntag.

    @rix0rrr
    rix0rrr authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    87eca86 View commit details
    Browse the repository at this point in the history

  2. 'removedTags' is unused now

    @rix0rrr
    rix0rrr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    9d8119b View commit details
    Browse the repository at this point in the history

  3. Default argument to empty object

    @rix0rrr
    rix0rrr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    d0281ee View commit details
    Browse the repository at this point in the history

  4. Refactor a bit so that the TagManager works with tags that are mostly… 

    … defined

The defaulting happens at the surface that the user interacts with,
which makes the backend easier to write because it has less
case analysis and exceptions to think about.
    @rix0rrr
    rix0rrr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    e026e52 View commit details
    Browse the repository at this point in the history

  5. Remove the internal 'Tag' type from public exposure

    @rix0rrr
    rix0rrr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    5724be9 View commit details
    Browse the repository at this point in the history