Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): propagate EC2 tags to volumes #17840

Merged
merged 7 commits into from
Dec 9, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Dec 3, 2021

aws-cloudformation/cloudformation-coverage-roadmap#133 just shipped.

Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-propagatetagstovolumeoncreation

Waiting on cloudfromation specs to get bumped to the latest version. Depends on #17844.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 3, 2021

@robertd robertd marked this pull request as draft December 3, 2021 22:52
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 3, 2021
@robertd robertd changed the title WIP: feat(ec2): propagate EC2 tags to volumes feat(ec2): propagate EC2 tags to volumes Dec 3, 2021
mergify bot pushed a commit that referenced this pull request Dec 8, 2021
Generated by running `./scripts/bump-cfnspec.sh`. Needed some additions required for #17840.

Closes #17858 (duplicate)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@robertd robertd marked this pull request as ready for review December 8, 2021 19:18
@robertd
Copy link
Contributor Author

robertd commented Dec 9, 2021

@njlynch This PR is ready for your review when you get a chance. 👍

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f527c67
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 42cf186 into aws:master Dec 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@robertd robertd deleted the prpagate-ec2-tags-to-volumes branch December 9, 2021 18:46
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Generated by running `./scripts/bump-cfnspec.sh`. Needed some additions required for aws#17840.

Closes aws#17858 (duplicate)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
aws-cloudformation/cloudformation-coverage-roadmap#133 just shipped.

Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-propagatetagstovolumeoncreation

Waiting on cloudfromation specs to get bumped to the latest version. Depends on aws#17844.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants