Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamodb): changing waitForReplicationToFinish fails deployment #17842

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Dec 4, 2021

Our CFN Custom Resource for global DynamoDB Tables did not correctly handle changing the
waitForReplicationToFinish parameter introduced in #16983 -
adding it to an existing replica would error out by attempting to re-create the existing replica.
Fix this by adding a check in the Custom Resource whether a replica already exists.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Our CFN Custom Resource for global DynamoDB Tables did not correctly handle changing the
`waitForReplicationToFinish` parameter introduced in aws#16983 -
adding it to an existing replica would error out by attempting to re-create the existing replica.
Fix this by adding a check in the Custom Resource whether a replica already exists.
@gitpod-io
Copy link

gitpod-io bot commented Dec 4, 2021

@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Dec 4, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e136881
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 36b8fdb into aws:master Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the dynamodb-global-no-wait branch December 6, 2021 18:33
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…aws#17842)

Our CFN Custom Resource for global DynamoDB Tables did not correctly handle changing the
`waitForReplicationToFinish` parameter introduced in aws#16983 -
adding it to an existing replica would error out by attempting to re-create the existing replica.
Fix this by adding a check in the Custom Resource whether a replica already exists.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants