Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wafv2): add WebAcl L2 Construct #17878

Closed
wants to merge 6 commits into from

Conversation

yamatatsu
Copy link
Contributor

This PR is implementation for #17749.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 7, 2021

@pahud
Copy link
Contributor

pahud commented Dec 7, 2021

Hey @kimisme9386 are you able to take a look?

@njlynch njlynch added effort/large Large work item – several weeks of effort p2 labels Dec 7, 2021
@kimisme9386
Copy link
Contributor

@yamatatsu
I have some questions and suggestions as below:

  1. According to your design in issue (wafv2): add WebACL L2 Construct #17749, it seems to me that it doesn't implement wafv2Statement class ? I think it is a great idea for using the WebAcl L2 Construct because it has more expressive for this L2 construct.

  2. In my opinion, It's a good way if the name property within wafv2Statement.ManagedRuleGroupStatement use enum and constant instead of string, such as wafv2Statement.AWS_MANAGED_RULES_COMMON_RULESET, AWS_MANAGED_RULES_ADMIN_PROTECTION_RULESET , wafv2Statement.AWS_MANAGED_RULES_KNOWN_BADINPUTS_RULESET, etc..., It's total 12 rules in this docs.

  3. Does you considerate support AWS WAF lable for this L2 construct ? It's also a good feature.

@yamatatsu
Copy link
Contributor Author

yamatatsu commented Dec 15, 2021

@kimisme9386

I'm assuming Statement classes! It will be implemented with IStatement and classes each statements, as aws-events-targets and aws-sns-subscriptions (I haven't decide yet which to create another package or not).

I think so too! Users will be able to choice from candidates with code documentations and get detail from @see links. It will be helpful. I think.

I have not design that feature yet😵. I described WebAcl CFn template as this, and I thought It is better to design core of WebAcl at first. I beleave L2 WebAcl Class I designed can be base of that feature😉.

@njlynch njlynch assigned skinny85 and unassigned njlynch Feb 1, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1dbaa01
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@skinny85 skinny85 removed their assignment Apr 28, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 5, 2022
@github-actions github-actions bot closed this May 5, 2022
@jacido
Copy link

jacido commented Jun 11, 2024

Is there another link this is being worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-wafv2 closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants