Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appsync): empty caching config is created when not provided #17947

Merged
merged 2 commits into from
Dec 10, 2021
Merged

fix(appsync): empty caching config is created when not provided #17947

merged 2 commits into from
Dec 10, 2021

Conversation

otaviomacedo
Copy link
Contributor

If the cachingConfig property is not provided, the library is generating an empty config.

Change this to not add any config to the template.

Related to #17925.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2021
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Dec 10, 2021
@otaviomacedo otaviomacedo requested a review from a team December 10, 2021 11:07
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4b27c9e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3a9f206 into master Dec 10, 2021
@mergify mergify bot deleted the otaviom/appsync-optional-caching-config branch December 10, 2021 13:41
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@otaviomacedo @TikiTDO
fix(appsync): empty caching config is created when not provided (aws#…
83fc704 
…17947)

If the `cachingConfig` property is not provided, the library is generating an empty config.

Change this to not add any config to the template.

Related to aws#17925.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/aws-appsync Related to AWS AppSync contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otaviomacedo @aws-cdk-automation @rix0rrr @njlynch