feat(cfnspec): cloudformation spec v51.0.0

[robertd]

Closes #17943.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[robertd]

Just checking to see why is #17943 failing to build properly. I cannot replicate this on my Mac.

edit: I had to run git clean -fqdx . first.

[robertd]

I do see that docs are completely missing Type property...

[robertd]

Actually... examples are missing too...

[robertd]

Hmm... AWS Lex docs are nowhere to be found in https://github.com/awsdocs/aws-cloudformation-user-guide/ repo, but they are present on the AWS User Guide page: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/AWS_Lex.html

[skinny85]

Thanks for your work on this @robertd! Two things:

1. Let's just remove the incorrect Property types, instead of guessing they are a string.
2. Can you check whether you can now remove the patches introduced in the previous PR (feat(cfnspec): cloudformation spec v50.0.0 #17844)?

Thanks,
Adam

[robertd]

1. Let's just remove the incorrect Property types, instead of guessing they are a string.

Removing the Type property from AWS::Lex::BotAlias.TextLogDestination.Properties.CloudWatch still throws an error. It looks like Type (or PrimitiveType) is a required param. Should I instead remove AWS::Lex::BotAlias.TextLogDestination section altogether?

2. Can you check whether you can now remove the patches introduced in the previous PR (feat(cfnspec): cloudformation spec v50.0.0 #17844)?

Removed AWS::Evidently patches introduced in #17844. Build and test passed on my machine. Pushed fd37bf8.

[skinny85]

1. Let's just remove the incorrect Property types, instead of guessing they are a string.

Removing the Type property from AWS::Lex::BotAlias.TextLogDestination.Properties.CloudWatch still throws an error. It looks like Type (or PrimitiveType) is a required param. Should I instead remove AWS::Lex::BotAlias.TextLogDestination section altogether?

Sure, that should work.

Or remove AWS::Lex::BotAlias.TextLogDestination.Properties.CloudWatch.

[robertd]

@skinny85 Done. Build is passing now. 👍

1. Should we make a note (GH Issue) to revisit this in the future cfnspec bumps?
2. I see bunch of other patches that are probably not needed anymore. Should we clean these up at some point?
3. Can you point me to the "official cfnspec patching how-to documentation" (if it exists). I'd like to learn more about it :) (i.e. resource patching vs property patching, available operations/commands, etc).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[skinny85]

@skinny85 Done. Build is passing now. 👍

Thanks for all your work on these CFN spec updates @robertd!

1. Should we make a note (GH Issue) to revisit this in the future cfnspec bumps?

That would be great!

2. I see bunch of other patches that are probably not needed anymore. Should we clean these up at some point?

We absolutely should! I don't expect you to handle that though, I think you've done enough 🙂.

3. Can you point me to the "official cfnspec patching how-to documentation" (if it exists). I'd like to learn more about it :) (i.e. resource patching vs property patching, available operations/commands, etc).

There is no official documentation for this, as not many tools use the CFN spec, and even less of them patch it 🙂. The mechanism we use I'm fairly sure we "borrowed" (😉) from the cfnlint tool.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 6d4d112
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[dontirun]

It looks like like v60.0.0 of the spec supports this property properly