Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): cannot use CA bundle and proxy at the same time #17990

Merged
merged 8 commits into from
Jan 3, 2022
Merged

fix(cli): cannot use CA bundle and proxy at the same time #17990

merged 8 commits into from
Jan 3, 2022

Conversation

zradlo1984
Copy link
Contributor

fixes #5804
This is reworked solution I proposed 30.11.2021 in PR #16704 on current master.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@zradlo1984 zradlo1984 changed the title Feature/5804 support both ca and proxy at same time fix(cli): Allow use CA bundle and proxy at the same time (aws#5804) Dec 13, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 13, 2021
@gitpod-io
Copy link

gitpod-io bot commented Dec 13, 2021

@rix0rrr rix0rrr changed the title fix(cli): Allow use CA bundle and proxy at the same time (aws#5804) fix(cli): cannot use CA bundle and proxy at the same time Jan 3, 2022
rix0rrr
rix0rrr previously approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The as any scared me, but I just confirmed it works. Thanks!

@mergify mergify bot dismissed rix0rrr’s stale review January 3, 2022 13:48

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c636103
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3d478ca into aws:master Jan 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@zradlo1984 @TikiTDO
fix(cli): cannot use CA bundle and proxy at the same time (aws#17990)
c5aef3e 
fixes aws#5804
This is reworked solution I proposed 30.11.2021 in PR aws#16704 on current master.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: support custom CA bundles while using a proxy
3 participants
@zradlo1984 @aws-cdk-automation @rix0rrr