fix(opensearchservice): imported domain's domainendpoint is a url not an endpoint
#18027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2021 01:01
|
|
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
joejegan
changed the title
kaizencc
changed the title
domainendpoint is a url not an endpoint
github-actions
bot
added
the
@aws-cdk/aws-opensearch
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
|
Whoops. I'm glad this didn't get merged because this is a breaking change to a stable module, which is not allowed. Users may be using This may be an allowed breaking change, but at the very least we'd have to document it. Give me a second to figure it out. |
kaizencc
previously approved these changes
Dec 20, 2021
kaizencc
changed the title
domainendpoint is a url not an endpointdomainendpoint is a url not an endpoint
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
kaizencc
added
the
pr/breaking-change
|
Now this PR relies on #18102. It's a little controversial; we may have to find some other workaround. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
…18102) This PR introduces a proposed new label, `pr-linter/exempt-breaking-change` that, when added, circumvents the check that asserts stable modules do not have breaking changes. Motivation: A situation like #18027 where we have are willing to accept a functional breaking change to a stable module. The regular `allowed-breaking-changes.txt` file does not work here, since there is no breaking change to the API. We want to be able to document the breaking change, but by documenting we alert `prlint` that we are breaking a stable module. Counterargument: Functional breaking changes were explicitly banned in #14861. From the PR description: "The CDK must be more strict on preventing such changes and the impact due to their perception." I also added some "manual linting" to the file myself since it was bothering me, and now it muddies the diff. Sorry! ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
kaizencc
added
pr-linter/exempt-breaking-change
kaizencc
approved these changes
Dec 21, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#18102) This PR introduces a proposed new label, `pr-linter/exempt-breaking-change` that, when added, circumvents the check that asserts stable modules do not have breaking changes. Motivation: A situation like aws#18027 where we have are willing to accept a functional breaking change to a stable module. The regular `allowed-breaking-changes.txt` file does not work here, since there is no breaking change to the API. We want to be able to document the breaking change, but by documenting we alert `prlint` that we are breaking a stable module. Counterargument: Functional breaking changes were explicitly banned in aws#14861. From the PR description: "The CDK must be more strict on preventing such changes and the impact due to their perception." I also added some "manual linting" to the file myself since it was bothering me, and now it muddies the diff. Sorry! ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ot an endpoint (aws#18027) imported Domain's domainEndpoint should be a endpoint and not a url. Fixes [aws#18017](aws#18017) BREAKING CHANGE: imported domain property `domainEndpoint` used to contain `https://` prefix, now the prefix is dropped and it returns the same value as a `domainEndpoint` on a created domain ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imported Domain's domainEndpoint should be a endpoint and not a url.
Fixes #18017
BREAKING CHANGE: imported domain property
domainEndpointused to containhttps://prefix, now the prefix is dropped and it returns the same value as adomainEndpointon a created domainBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license