feat(servicediscovery): AWS Cloud Map construct library #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a README and probably a few more tests, but wanted to get this up for initial review. This is preliminary work for ECS service discovery integration (can follow progress on WIP branch here) |
eladb
changed the title
eladb
previously requested changes
Feb 20, 2019
rix0rrr
reviewed
Feb 20, 2019
jogold
reviewed
Feb 20, 2019
SoManyHs
force-pushed
the
servicediscovery
branch
2 times, most recently
from
fb3bef4 to
c284a09
Compare
SoManyHs
force-pushed
the
servicediscovery
branch
from
ea189f4 to
48c262f
Compare
rix0rrr
approved these changes
Mar 6, 2019
packages/@aws-cdk/aws-servicediscovery/test/integ.service-with-http-namespace.ts
Outdated
Show resolved
Hide resolved
SoManyHs
force-pushed
the
servicediscovery
branch
6 times, most recently
from
51c4693 to
ca15e65
Compare
rix0rrr
reviewed
Mar 8, 2019
RomainMuller
reviewed
Mar 8, 2019
packages/@aws-cdk/aws-servicediscovery/test/integ.service-with-http-namespace.lit.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-servicediscovery/test/integ.service-with-http-namespace.lit.ts
Outdated
Show resolved
Hide resolved
eladb
reviewed
Mar 11, 2019
| * | ||
| * @default none | ||
| */ | ||
| healthCheckCustomConfig?: HealthCheckCustomConfig; |
There was a problem hiding this comment.
Don't use the suffix config both in property name and type name
| * | ||
| * @default none | ||
| */ | ||
| healthCheckConfig?: HealthCheckConfig; |
SoManyHs
force-pushed
the
servicediscovery
branch
from
f7eb578 to
36f5e1c
Compare
SoManyHs
force-pushed
the
servicediscovery
branch
2 times, most recently
from
30c22de to
75b0a3e
Compare
4 tasks
jogold
reviewed
Mar 12, 2019
packages/@aws-cdk/aws-servicediscovery/lib/private-dns-namespace.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-servicediscovery/lib/private-dns-namespace.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Mar 12, 2019
|
Have you seen this #1804 (comment)? Do you want to do something at this stage? |
Partially addresses aws#1554
`instanceId` is an arbitrary identifier for an instance registered to a Cloud Map service. It is not particularly useful to the customer, but due to science it is required on a RegisterInstance API call. This makes instanceId an optional prop as it was meant to be on the instance constructs.
HealthCheckConfig can be specified for HTTP namespaces after all
SoManyHs
force-pushed
the
servicediscovery
branch
from
e00bb06 to
bbd14fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1554
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.