-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipelines): add example of the modern API with an ECS deployment #18042
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Doesn't look the failed code build is related to my change.
|
@rix0rrr you want to take this one? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I'm sorry, but this is not how CDK pipelines is intended to be used. In CDK pipelines, we deploy all changes via CloudFormation: that includes updates to your ECS service. If you want to deploy other scenarios, you can build whatever shape of pipeline you prefer with full control by using the Yes, you can use the custom step facility of CDK pipelines and use it as a convenient front-end over the CodePipeline module, and get pretty close to arbitrary pipelines. But this is not how we recommend you use the library, and so we will not include how-tos on how to achieve that into the upstream repository. |
Troubleshooting why my ECS is not deploying led me to here. Using CloudFormation to deploy ECS is indeed easier than rigging your own ECS deployment step/action. There are however 2 important things I wish CDK docs would call out:
We previously built our own ECR image with Codebuild step and had part of the build cmds in CodeBuild step, and took significant time to refactor this. It is also not a perfect solution - we are no longer able to retrieve Github SSH key from Secrets Manager for instance. |
Provides tests as examples to #17558 for deploy ECS with the modern CDK pipeline API.
closes #17558
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license