-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docdb): allow setting log retention #18120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jumic! Just a small naming comment.
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed changing the docs, and I missed a redundant condition in an if
😃.
Pull request has been modified.
Thanks for your feedback. The suggested changes have been implemented. :) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Provide an option to configure the number of days log events are kept in CloudWatch Logs. Properties `cloudwatchLogsRetention` and `cloudwatchLogsRetentionRole` are added to `DatabaseClusterProps`. Closes aws#13191. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Provide an option to configure the number of days log events are kept in CloudWatch Logs.
Properties
cloudwatchLogsRetention
andcloudwatchLogsRetentionRole
are added toDatabaseClusterProps
.Closes #13191.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license