Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): hotswap deployments for CodeBuild projects #18161

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

madeline-k
Copy link
Contributor

@madeline-k madeline-k commented Dec 23, 2021

This extends the cdk deploy --hotswap command to support CodeBuild projects.

This supports all changes to the Source, SourceVersion, and Environment attributes of the AWS::CodeBuild::Project cloudformation resource. The possible changes supported on the Project L2 Construct will be changes to the buildSpec, environment, environmentVariables, and source constructor props.

Closes #17566


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 23, 2021

@madeline-k madeline-k requested a review from skinny85 December 23, 2021 23:15
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 23, 2021
@madeline-k madeline-k requested a review from a team December 23, 2021 23:16
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4ae4df8 into aws:master Dec 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bc88176
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This extends the `cdk deploy --hotswap` command to support CodeBuild projects. 

This supports all changes to the `Source`, `SourceVersion`, and `Environment` attributes of the AWS::CodeBuild::Project cloudformation resource. The possible changes supported on the [Project](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-codebuild.Project.html) L2 Construct will be changes to the [buildSpec](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-codebuild.Project.html#buildspec), [environment](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-codebuild.Project.html#environment), [environmentVariables](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-codebuild.Project.html#environmentvariables), and [source](https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-codebuild.Project.html#source) constructor props.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cli): would be awesome if hotswap supported CodeBuild
3 participants