fix(ecs): respect LogGroup's region for aws-log-driver #18212
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-ecs
Respect passed log group `region` when constructing an instance of `AwsLogDriver`. That change allows to implement cross region logging pattern for ECS containers. fixes aws#17747
kornicameister
force-pushed
the
fix_17747
branch
from
18bdb21 to
64502b1
Compare
|
Alright, let's see if that one works now. |
|
@madeline-k @skinny85 thanks to fix from another issue, this change now allows to have correct region when using imported log group. |
There was a problem hiding this comment.
Thanks for contributing this fix, @kornicameister ! Looks great, I just have one tiny suggestion.
Add suggestion from code review
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
There was a problem hiding this comment.
Applied my small suggestion myself. Approving! Thanks, @kornicameister!
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Respect passed log group `region` when constructing an instance of `AwsLogDriver`. That change allows to implement cross region logging pattern for ECS containers. fixes aws#17747 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Respect passed log group
regionwhen constructing an instance ofAwsLogDriver.That change allows to implement cross region logging pattern for ECS containers.
fixes #17747
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license