Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqs): add DLQ readonly property to Queue #18232

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

markmansur
Copy link
Contributor

@markmansur markmansur commented Dec 31, 2021

feat(@aws-cdk/aws-sqs): add DLQ readonly property

motivation is to be able to read the DLQ properties after the queue as been created. Such as referencing it in a different stack.

#18083

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 31, 2021

@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Dec 31, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@njlynch njlynch changed the title feat(@aws-cdk/aws-sqs): add DLQ readonly property feat(sqs): add DLQ readonly property to Queue Jan 4, 2022
@njlynch njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 600d9a5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit caa6788 into aws:master Jan 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@markmansur markmansur deleted the markmansur/dlq-readonly-property branch January 5, 2022 03:23
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
feat(@aws-cdk/aws-sqs): add DLQ readonly property

motivation is to be able to read the DLQ properties after the queue as been created. Such as referencing it in a different stack.

aws#18083  
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants