Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pipelines): add philosophy disclaimer #18244

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 3, 2022

People keep on wanting to do their CodeDeploy deployments (to
either ASGs or ECS clusters) in CDK Pipelines directly.

While this is possible using custom steps, it's not how the library
is intended to be used. Explain that up top in the README.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

People keep on wanting to do their CodeDeploy deployments (to
either ASGs or ECS clusters) in CDK Pipelines directly.

While this is *possible* using custom steps, it's not how the library
is intended to be used. Explain that up top in the README.
@rix0rrr rix0rrr requested a review from a team January 3, 2022 13:18
@rix0rrr rix0rrr self-assigned this Jan 3, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 3, 2022

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Jan 3, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 41ec65a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9b6e237 into master Jan 3, 2022
@mergify mergify bot deleted the huijbers/pipelines-philosophy branch January 3, 2022 15:59
@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
People keep on wanting to do their CodeDeploy deployments (to
either ASGs or ECS clusters) in CDK Pipelines directly.

While this is *possible* using custom steps, it's not how the library
is intended to be used. Explain that up top in the README.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants