chore: skip post_build on build failure #18365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs on CodeBuild [build transitions], the `POST_BUILD` step is always run after `BUILD`, even if `BUILD` fails. This can mean in our pipeline we can fail the build, and then wait for the (currently very expensive) packing step to run completely before the job fails. This change short-circuits the logic so we only run pack if the build succeeded. [build transitions]: https://docs.aws.amazon.com/codebuild/latest/userguide/view-build-details.html
|
|
otaviomacedo
approved these changes
Jan 11, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Jan 12, 2022
The buildspec was recently altered (in #18365) to skip the `POST_BUILD`/pack step if the build failed; however, the command used was bash-specific and not compliant with CodeBuild. Rewrite the check to be sh-compliant.
njlynch
added a commit
that referenced
this pull request
Jan 12, 2022
The buildspec was recently altered (in #18365) to skip the `POST_BUILD`/pack step if the build failed; however, the command used was bash-specific and not compliant with CodeBuild. Rewrite the check to be sh-compliant.
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
The buildspec was recently altered (in #18365) to skip the `POST_BUILD`/pack step if the build failed; however, the command used was bash-specific and not compliant with CodeBuild. Rewrite the check to be sh-compliant. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
According to the docs on CodeBuild [build transitions], the `POST_BUILD` step is always run after `BUILD`, even if `BUILD` fails. This can mean in our pipeline we can fail the build, and then wait for the (currently very expensive) packing step to run completely before the job fails. This change short-circuits the logic so we only run pack if the build succeeded. [build transitions]: https://docs.aws.amazon.com/codebuild/latest/userguide/view-build-details.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The buildspec was recently altered (in aws#18365) to skip the `POST_BUILD`/pack step if the build failed; however, the command used was bash-specific and not compliant with CodeBuild. Rewrite the check to be sh-compliant. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs on CodeBuild build transitions, the
POST_BUILDstep isalways run after
BUILD, even ifBUILDfails. This can mean in our pipelinewe can fail the build, and then wait for the (currently very expensive) packing
step to run completely before the job fails. This change short-circuits the
logic so we only run pack if the build succeeded.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license