Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): add vpc configuration #18447
feat(synthetics): add vpc configuration #18447
Changes from 23 commits
80cbb5b
432eea0
0c23ec0
c293aa5
e7941a0
cde330c
12d2d10
303cb7e
8b8ac53
7ca0270
c2ef535
daa317f
2b0778c
48c0ebc
2d0a396
d543203
343ee82
6449e13
8e38971
adb0f98
1445e2e
5eeefae
c29d7a6
2a38371
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fail synth if a user tries to set vpc related options without setting
vpc
. Right now they look to be just ignored in that case, which might be cause for confusion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the two places I took for inspiration don't explicitly do this, but I think it's a good idea.