Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): warning to upgrade to bootstrap version >= undefined #18489

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix(cli): warning to upgrade to bootstrap version >= undefined #18489

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ceefe5
fix(cli): warning to upgrade to bootstrap version >= undefined
corymhall Jan 18, 2022
104fe18
add test
corymhall Jan 18, 2022
46eeec7
Merge branch 'master' into corymhall/bootstrap-version-fix
mergify[bot] Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/aws-cdk/lib/api/cloudformation-deployments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,20 @@ export async function prepareSdkWithLookupRoleFor(
if (version < stack.lookupRole.requiresBootstrapStackVersion) {
throw new Error(`Bootstrap stack version '${stack.lookupRole.requiresBootstrapStackVersion}' is required, found version '${version}'.`);
}
} else if (!stackSdk.didAssumeRole) {
// we may not have assumed the lookup role because one was not provided
// if that is the case then don't print the upgrade warning
} else if (!stackSdk.didAssumeRole && stack.lookupRole?.requiresBootstrapStackVersion) {
warning(upgradeMessage);
}
return { ...stackSdk, resolvedEnvironment };
} catch (e) {
debug(e);
warning(warningMessage);
warning(upgradeMessage);
// only print out the warnings if the lookupRole exists AND there is a required
// bootstrap version, otherwise the warnings will print `undefined`
if (stack.lookupRole && stack.lookupRole.requiresBootstrapStackVersion) {
warning(warningMessage);
warning(upgradeMessage);
}
throw (e);
}
}
Expand Down