Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolkit): support diff on multiple stacks #1855

Merged
merged 5 commits into from
Feb 28, 2019

Commits on Feb 25, 2019

  1. fix(toolkit): support diff on multiple stacks

    If there are stack dependencies, 'diff' would fail because it does not
    know how to diff multiple stacks. Make diff support the same stack
    selection mechanisms as 'cdk deploy'.
    
    Move 'stack rename' facilities into the class that deals with the
    CDK app, which is the source of thruth for stacks. This way, all
    downstream code doesn't have to deal with the renames every time.
    
    Start factoring out toolkit code into logical layers. Introducing
    the class `CdkToolkit`, which represents the toolkit logic and
    forms the bridge between `AppStacks` which deals with the CDK
    model source (probably needs to be renamed to something better)
    and `CfnProvisioner`, which deals with the deployed stacks.
    
    N.B.: The indirection to a provisioner class with an interface is
    because the interface is going to be complex (therefore, interface
    over a set of functions that take callbacks) and we want to depend
    just on the interface so it's easy to stub out for testing.
    Rico Huijbers committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    a315a05 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Be compatible with version of Writable on build server

    Rico Huijbers committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    4277db6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Change type the other way

    rix0rrr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    7f31bf4 View commit details
    Browse the repository at this point in the history
  2. Review tweaks

    rix0rrr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    a0edb71 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/master' into huijbers/multi-stac…

    …k-diff
    Rico Huijbers committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    5910f54 View commit details
    Browse the repository at this point in the history