Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53): add RoutingControlArn to HealthCheck patch #18645

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Jan 25, 2022

The Route53 HealthCheckConfig structure is modeled in the CloudFormation spec as
a JSON blob, but it was previously modeled as an explicit structure (see
structure, as it's not updated with the Route53 spec. This adds the missing
RoutingControlArn to the structure.

fixes #18570


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The Route53 HealthCheckConfig structure is modeled in the CloudFormation spec as
a JSON blob, but it was previously modeled as an explicit structure (see
structure, as it's not updated with the Route53 spec. This adds the missing
RoutingControlArn to the structure.

fixes #18570
@njlynch njlynch requested a review from a team January 25, 2022 12:55
@njlynch njlynch self-assigned this Jan 25, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 25, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2022

@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label Jan 25, 2022
@njlynch njlynch added the pr-linter/exempt-test The PR linter will not require test changes label Jan 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 53076d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c58e8bb into master Jan 26, 2022
@mergify mergify bot deleted the njlynch/route53-routingcontrolarn branch January 26, 2022 12:11
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
The Route53 HealthCheckConfig structure is modeled in the CloudFormation spec as
a JSON blob, but it was previously modeled as an explicit structure (see
structure, as it's not updated with the Route53 spec. This adds the missing
RoutingControlArn to the structure.

fixes aws#18570


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-route53): HealthCheckConfigProperty missing RoutingControlArn
3 participants