Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update verify-imports-resolve-same to ignore module extensions #19096

Merged
merged 1 commit into from
Feb 22, 2022
Merged

build: update verify-imports-resolve-same to ignore module extensions #19096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/scripts/verify-imports-resolve-same.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ async function compileAndResolve(fileName: string, contents: string, symbolName:
}

// Return the filename
const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/.ts|.js|.d.ts/, '');
const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/[.](ts|js|d\.ts)$/, '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe also escape the first . here, instead of using a one-element class, since we do that later in the regex anyway, so it's better to be consistent...?

Suggested change
const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/[.](ts|js|d\.ts)$/, '');
const srcFile = sym.declarations?.[0].getSourceFile().fileName.replace(/\.(ts|js|d\.ts)$/, '');

if (!srcFile) {
console.log(sym);
throw new Error(`Symbol ${symbolName} in '${contents}' does not resolve to a source location`);
Expand Down