fix: Apply suggested fix from @fcoelho to support podman #19115
Conversation
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
rosskarchner
changed the title
|
I don't think the build failures have anything to do with the change I've introduced |
|
This PR has been in BUILD FAILING for 21 days, and looks abandoned. It will be closed in 10 days if no further commits are pushed to it. |
| @@ -70,7 +70,7 @@ export class Docker { | |||
| await this.execute(['login', | |||
| '--username', credentials.username, | |||
| '--password-stdin', | |||
| credentials.endpoint], { | |||
| credentials.endpoint.replace(/^https?:\/\//, '')], { | |||
There was a problem hiding this comment.
| credentials.endpoint.replace(/^https?:\/\//, '')], { | |
| credentials.endpoint.replace(/^https?:\/\/|\/$/g, '')], { |
Remove end slash too considering that the test data included an end slash in the endpoint.
There was a problem hiding this comment.
@rosskarchner Tests also need to be fixed in packages/cdk-assets/test/docker-images.test.ts
Here is one test that is failing
I believe there are four total that use https
There was a problem hiding this comment.
@Ragnoroct thanks, I'll take a look at these (once I get a working environment to test with)
Co-authored-by: Will Bender <willypbender83@gmail.com>
|
OK-- I've moved on from needing this (I'm no longer attempting to run CDK with podman), and I'm feeling a little out of my depth trying to understand the test suite. I'm going to go ahead and close this. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The code comes from this comment: #16209 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license