fix: apply tags to nested stack #19128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudformation
When a nested stack gets a custom tags the tag gets applied only to the resources defined in the stack and not the stack itself. This change fixes this issue and applies the tag to the nested stack as well This was caused by NestedStack subclassing Stack but not using the NestedStack.tags in the CfnStack resource that was created by it and not rendering the tags that were added when creating the AWS::CloudFormation::Stack. This change updates the `_prepareTemplateAsset` to get all the tags added to the nested stacks instance TagManager and add them to the CfnStack before rendering the assets fixes aws#17463
rix0rrr
approved these changes
Feb 26, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a nested stack gets a custom tags the tag gets applied only to the resources defined in the stack and not the stack itself. This change fixes this issue and applies the tag to the nested stack as well. This was caused by NestedStack subclassing Stack but not using the NestedStack.tags in the
CfnStack(as it accepts onlyCfnTag[]and notTagManager)This change updates the
_prepareTemplateAssetto get all the tags added to theCfnStackfromNestedStack.tagbefore rendering the stackfixes #17463
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license