Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'ubergen exclude' from example package #19177

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 26, 2022

The example construct library package comes with
ubergen { exclude: true } configured by default. We do want new construct
libraries included into ubergen by default, though.

I got into a little fight with pkglint: it said that private packages must always have ubergen: exclude set, but this package should be private but not have the exclude flag set.

Seems simpler to just exclude private packages from ubergen by default, without the middle man of the exclude flag.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The example construct library package comes with
`ubergen { exclude: true }` configured by default. This leads to
mistakes.
@rix0rrr rix0rrr requested a review from a team February 26, 2022 16:54
@rix0rrr rix0rrr self-assigned this Feb 26, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 26, 2022

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Feb 26, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b91a30a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c94c277 into master Mar 18, 2022
@mergify mergify bot deleted the huijbers/no-exclude branch March 18, 2022 09:38
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

otaviomacedo added a commit that referenced this pull request Mar 24, 2022
mergify bot pushed a commit that referenced this pull request Mar 24, 2022
…package (#19177)" (#19540)

This reverts commit c94c277.

In the `v2-main` branch all packages are private, which causes ubergen to exclude all of them, which we don't want.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…package (aws#19177)" (aws#19540)

This reverts commit c94c277.

In the `v2-main` branch all packages are private, which causes ubergen to exclude all of them, which we don't want.

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants